Re: ditaa --svg option is missing when building doc/src/sgml/images

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: ditaa --svg option is missing when building doc/src/sgml/images
Date: 2025-12-22 12:35:31
Message-ID: CAN55FZ05G4jG+gEVRxMBSpY5miT-JS+DOn0z13D1ydpaUXZhJQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for looking into this!

On Fri, 19 Dec 2025 at 18:39, Paul A Jungwirth
<pj(at)illuminatedcomputing(dot)com> wrote:
>
> On Fri, Dec 19, 2025 at 5:52 AM Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> >
> > I am working on writing a meson.build file for doc/src/sgml/images,
> > but I ran into an issue when Meson tries to invoke `ditaa`:
> >
> > ...
> >
> > This issue also happens on autoconf builds:
> >
> > ...
> >
> > It appears that the --svg option was introduced in ditaa v0.11.0 [1],
> > while Debian ships ditaa v0.10.x [2], which does not support this
> > option.
> >
> > Additionally, doc/src/sgml/images/README mentions: Ditaa
> > (http://ditaa.sourceforge.net/) but this website has an even older
> > version, v0.9.*.
> >
> > If I am not missing anything, what do you think about updating this
> > URL with the github URL [3]?
> >
> > [1] https://github.com/stathissideris/ditaa
> > [2] https://packages.debian.org/sid/ditaa
>
> Nice archeology! I ran into this too when I was adding the images for
> temporal PKs & FKs. It worked on a Mac with the brew ditaa, but not on
> debian, until I installed it from github. Changing the link seems like
> a good solution.

It looks like brew ditaa is also v0.11.0 [1].

After thinking a bit more, I think it would be better to add version
requirement information too; something like:

-- Ditaa (http://ditaa.sourceforge.net/)
+- Ditaa (https://github.com/stathissideris/ditaa) (version 0.11.0 or
+ later)

What do you think?

[1] https://formulae.brew.sh/formula/ditaa

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marcos Pegoraro 2025-12-22 13:28:43 Re: Get rid of "Section.N.N.N" on DOCs
Previous Message cca5507 2025-12-22 12:35:00 Re: [PATCH] Why is_admin_of_role() uses ROLERECURSE_MEMBERS ratherthan ROLERECURSE_PRIVS?