Re: BUG #19095: Test if function exit() is used fail when linked static

From: Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: VASUKI M <vasukim1992002(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, BharatDB <bharatdbpg(at)gmail(dot)com>, torsten(dot)rupp(at)gmx(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: 2025-12-09 12:47:13
Message-ID: CAN55FZ03oW7zGiCgLfeiRxDQ5NLbyrppP1=mFpQ7QoDkbs84JA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi,

On Tue, 9 Dec 2025 at 13:23, VASUKI M <vasukim1992002(at)gmail(dot)com> wrote:
>
> Thanks Michael and Peter for the detailed reviews and for taking the time to refine and commit the updated version.
>
> Thanks for pointing out that pgperltidy may behave differently across environments.
>
> On Tue, 9 Dec 2025 at 11:56, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>
>> The attached takes care of the issue here. Adding that to pgxs_bins
>> may look adapted at first glance, but I don't quite see the point in
>> exposing this information to PGXS, so pgxs_empty is a better fit?
>>
> Thanks for the clarification.Given that PGXS extensions don't appear to require NM ,IMO adding it to pgxs_empty makes sense to me.It resolves the Meson warning without exposing unnecessary variables to PGXS users.

I agree with both of you. We do the same thing for 'ZIC' binary, so I
think putting it to pgxs_empty is the correct fix.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Greg Sabino Mullane 2025-12-09 14:28:21 Re: BUG #19348: Disk space error when running COPY after upgrading to PostgreSQL 17.7
Previous Message weijie JL 2025-12-09 11:30:57 Re: BUG #19345: MemoryContextSizeFailure after upgrade 14.11 to 17.7 in stored procedure

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2025-12-09 12:58:40 Re: Make copyObject work in C++
Previous Message Jelte Fennema-Nio 2025-12-09 12:43:03 Re: Type assertions without GCC builtins