| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Gilles Darold <gilles(at)darold(dot)net>, japin <japinli(at)hotmail(dot)com>, Yuefei Shi <shiyuefei1004(at)gmail(dot)com>, songjinzhou <tsinghualucky912(at)foxmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, liu xiaohui <liuxh(dot)zj(dot)cn(at)gmail(dot)com>, Steven Niu <niushiji(at)gmail(dot)com> |
| Subject: | Re: Pasword expiration warning |
| Date: | 2026-02-06 09:53:43 |
| Message-ID: | CAN4CZFPyCiVjBKhTJhmY5J0hj0KBgVwFA3gBh+Bvvcra-DQyYA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Eh, there are lots of examples of setting the default value in both the GUC
> definition and the variable declaration. TBH I've always found excessive
> macro use to hinder readability more than it helps anything.
One thing that would help is readability, as macros/constants usually
have nice explanatory names. That could be improved by adding a "/* 7
days in seconds */" comment after the number, without a macro. But if
somebody searches for the guc name, it's already defined as 7d
elsewhere, so I'm not sure if this would be really useful.
The patch looks good to me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-02-06 10:00:14 | Re: Changing shared_buffers without restart |
| Previous Message | Laurenz Albe | 2026-02-06 09:40:02 | Re: client_connection_check_interval default value |