| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, VASUKI M <vasukianand0119(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, david(dot)g(dot)johnston(at)gmail(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, myon(at)debian(dot)org |
| Subject: | Re: Custom oauth validator options |
| Date: | 2026-04-06 22:09:27 |
| Message-ID: | CAN4CZFPCHdY2j1+EHDhU+G+8+bp_jXh3Jqqf+2wqeYDBiQbjVA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I believe this is now a complete patch
> proposal; tear it apart. :D
The patch looks good to me as is, I don't see any real issues with it,
maybe one cosmetic question in the test.
+ if (GetOAuthHBAOption(state, "log"))
+ elog(LOG, "%s", GetOAuthHBAOption(state, "log"));
+
If we treat the test code as an example for real implementations, this
and the other use could cache the option in a local variable instead
of making duplicate calls, following the pattern of the documentation.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-04-06 22:16:55 | Re: Custom oauth validator options |
| Previous Message | Jacob Champion | 2026-04-06 22:01:14 | Re: DEREF_AFTER_NULL: src/common/jsonapi.c:2529 |