Re: Do we want to solve reload/config races more generally? (was: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace)

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Do we want to solve reload/config races more generally? (was: Postmaster crashes on SIGHUP when oauth_validator_libraries holds only whitespace)
Date: 2026-10-10 09:47:11
Message-ID: CAN4CZFP7ZMLB5Q1P4H__2d54om6fO+OEBZpWLpMwhFipobrEEw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hello

There's still a leftover empty validator issue, even if not that
serious: '""'. It returns a list with a single empty string, so the
new check doesn't catch it, the hba line gets a single empty named
validator.

This hits an assertion in debug builds, but otherwise works mostly
fine in release builds with a 'could not access file ""' error.

The attached patch adds an additional check for this.

Attachment Content-Type Size
v1-0001-oauth_validator-Reject-empty-library-names.patch application/octet-stream 2.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2026-10-10 09:57:49 Emptying oauth_validator_libraries doesn't stop OAuth logins
Previous Message Xuneng Zhou 2026-10-10 09:31:17 Re: Deadlock detector fails to activate on a hot standby replica

Browse pgsql-bugs by date

  From Date Subject
Previous Message Tom Lane 2026-10-09 20:27:44 Re: GIN disagrees with seq scan when NOT and AND operators are combined