| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | David Geier <geidav(dot)pg(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: Use correct collation in pg_trgm |
| Date: | 2026-01-26 13:24:15 |
| Message-ID: | CAN4CZFP5oVKkjAeb7-jrWR8spqvnhQq7HSTMhpWBiYuPmtqyjg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> While reading through [1] I realized that the word boundary detection
> also uses the wrong collation. Patch 0002 fixes that.
Good catch, I considered checking that when I reviewed the patch, but
I thought that it would be an issue with CJK languages, and I was
completely wrong about that.
Updated patch looks good, I only noticed two minor things:
* the new test should have a newline at the end of the file
* and probably a conditional skip based on locale availability, the
citext_utf8.sql test case does something similar
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-01-26 13:33:50 | Re: Use correct collation in pg_trgm |
| Previous Message | Anthonin Bonnefoy | 2026-01-26 13:16:45 | Re: Auto-tune shared_buffers to use available huge pages |