| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Gregory Burd <greg(at)burd(dot)me>, aleksander(at)tigerdata(dot)com |
| Subject: | Improve error handling in test modules: test_extensible, test_bitmapset |
| Date: | 2026-09-06 10:22:58 |
| Message-ID: | CAN4CZFOTQXMZvuPxweO4Fm7+sjrPJUqU-JvYKETLBxuhqgbPjw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
The recently added test extensible module has a small oversight: it
lacks input validation, which made it easy to crash the backend with
invalid input with the test module loaded. While this doesn't seem
like a critical issue for a test module, the commit message also
mentions that this could be a template for extension developers, so I
think it is worth fixing.
There's a similar issue in test_bitmapset: that's an older commit, but
it shows the same issue.
I attached fixes to both as 0001/0002.
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-test_bitmapset-Decode-arguments-with-readBitmapset.patch | application/octet-stream | 5.7 KB |
| 0001-test_extensible-Reject-other-node-types-before-calli.patch | application/octet-stream | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2026-09-06 10:45:52 | Re: Further cleanup related to statistics import support in postgres_fdw |
| Previous Message | Xuneng Zhou | 2026-09-06 09:11:18 | Re: Implement waiting for wal lsn replay: reloaded |