| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Nikolay Samokhvalov <nik(at)postgres(dot)ai>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: autovacuum: automatically propagate updated parameters |
| Date: | 2026-09-30 09:00:34 |
| Message-ID: | CAN4CZFOGQCy+fxtQEXHUqwF6gTLpNSdMtV9CxHC_0yd-f=NhBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I addressed these in v5. 0001 is unchanged.
> I think we could simplify the tests by
> introducing a boolean variable, say, leader_participates
> ...
I am not convinced that this change made things simpler, but it is
included in 0002.
> While not a problem with this patch, I wish wait_for_log could either return
> the match, or at least the offset of the match, and not just the size of the
> file. If we had that we could avoid reading excessive amounts of log data and
> reduce the risk of buggy tests matching on the wrong part of the log.
I ended up completely removing that test, it seemed redundant.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Refresh-autovacuum-costs-while-waiting-for-parall.patch | application/x-patch | 6.9 KB |
| v5-0002-Add-tests-for-cost-parameter-refresh-in-parallel-.patch | application/x-patch | 9.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rui Zhao | 2026-09-30 09:43:07 | Re: Do we want to avoid checksumming extra files in the datadir? [was: BUG #19647] |
| Previous Message | John Naylor | 2026-09-30 07:48:33 | Re: BUG #19705: One NaN box makes a BRIN box_inclusion_ops index omit unrelated rows |