| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Date: | 2026-08-15 14:30:56 |
| Message-ID: | CAN4CZFO+GqLpgJFPosg14RYOPESupXPyccwR=3jOcty_=SiGew@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Can we combine the two tests into a single 010_backup.pl to keep cluster
> inits down?
I reworked the tests with another injection point as part of this,
this way they shouldn't be flaky on CI and they are significantly
faster now.
> I'm not sure that "since the server started" is enough for a backup taken from
> a standby. XLogCtl is zeroed at startup, while the checksum state is restored
> from pg_control. The standby can become available before replay reaches the
> latest checksum transition, so verification could resume with
> lastChecksumChangeRecPtr invalid.
There was really an issue there, I think we can solve that by
advancing minrecoverypoint. I kept a test case for this separate for
now, as I am unsure if we want to include it in some form.
> I think that an atomic would make more sense.
Also done.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-basebackup-do-not-verify-checksums-on-pages-from-.patch | application/octet-stream | 29.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-08-15 15:11:07 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Imran Zaheer | 2026-08-15 12:28:07 | Re: Failing assertion while taking a restartpoint during crash recovery |