| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Improve OAuth discovery logging |
| Date: | 2026-02-25 13:14:48 |
| Message-ID: | CAN4CZFNWBXtF-ML3yzdOvX3QEuUwVo5VrBzyWU3O=y-7SeDstA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> "ctx->state = OAUTH_STATE_FINISHED;" is duplicated in the “if” and after the “if”, so it can be pull up to before the “if”.
It can't, because the if is based on ctx->state. If I move it to
before the if, I have to save the previous value, which just makes the
code longer.
I attached v4 with an edited commit message, nothing else changed.
Commitfest: https://commitfest.postgresql.org/patch/6529/
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Improve-OAuth-discovery-logging.patch | application/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-02-25 13:19:17 | Re: Fix XLogFileReadAnyTLI silently applying divergent WAL from wrong timeline |
| Previous Message | Daniel Gustafsson | 2026-02-25 13:10:43 | Re: pg_basebackup: removed an unnecessary use of memset in FindStreamingStart |