| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row |
| Date: | 2026-09-07 10:28:40 |
| Message-ID: | CAN4CZFNHExB699FKRpWwyXEox7B7TNXPvFWzWaF=jKjUe_KQfQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 07 Sep 2026, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:
> However, that fix seems to have the same kind of layering
> violation that Andres complained about for the first version of the
> patch on this thread -- predicate locking should be in heapam code,
> not in execIndexing.c.
It's not just the layering violation, that solution also has a
leftover issue, similarly to my first patch in this thread. When I
looked at this my initial conclusion was that we can't fix the two at
the same place without layering violations / remaining issues, so my
idea was to apply the same fix as I did for SELECT to those paths, but
I'll take another look at it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2026-09-07 11:04:14 | Re: COALESCE patch |
| Previous Message | Amit Kapila | 2026-09-07 10:26:24 | Re: Crashes on a partition whose concurrent detach never finished |