| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-03-17 05:06:08 |
| Message-ID: | CAN4CZFNEG7MEKFZ1-yJw3e2DtfKxExV6=8XOUciQ5JvksqkOWg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Thanks. The changes to the Makefile seem to mirror what is done in
> contrib/isn/Makefile, but I'm not so sure about the meson.build
> changes. sepgsql uses dir_data / 'contrib' rather than
> dir_include_server. src/pl/pl{perl,pgsql,python} use
> dir_include_server, but they also live in src/pl, not contrib. I don't
> think I understand what the underlying principal is supposed to be
> here. If you or anyone else knows, please enlighten me.
PGXS defines it as:
# HEADERS_$(MODULE) -- files to install into
# $(includedir_server)/$MODULEDIR/$MODULE; the value of $MODULE must be
# listed in MODULES or MODULE_big
where
# MODULEDIR -- subdirectory of $PREFIX/share into which DATA and DOCS files
# should be installed (if not set, default is "extension" if EXTENSION
# is set, or "contrib" if not)
And I mirrored that in meson.
Data seems to be wrong for headers, as that's
# DATA -- random files to install into $PREFIX/share/$MODULEDIR
> sepgsql uses dir_data / 'contrib'
Also, sepgsql installs an sql file, not an include.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haibo Yan | 2026-03-17 05:16:58 | Re: Return pg_control from pg_backup_stop(). |
| Previous Message | Amit Kapila | 2026-03-17 05:02:42 | Re: Report bytes and transactions actually sent downtream |