Re: Serverside SNI support in libpq

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Serverside SNI support in libpq
Date: 2026-09-23 08:10:19
Message-ID: CAN4CZFN1+-5k8hnC7845uYnYjR6h-ddZTDnoNNVDe4e_nDA7rQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

- if (!ssl_sni)
+ if ((SSL_hosts && !SSL_hosts->sni_enabled) || !ssl_sni)
(*openssl_tls_init_hook) (ctx, isServerStart);

together with

*
* If SNI is enabled, we set password callback based what was configured.
*/
- if (!ssl_sni)
+ if ((SSL_hosts && !SSL_hosts->sni_enabled) || !ssl_sni)
(*openssl_tls_init_hook) (ctx, isServerStart);
else
{

These block enabling sni with a config reload when using passphrases,
because it takes the global path and never installs the per-host
passphrase command. (Maybe the patch could pass another argument for
init_host_context instead?)

+# Reset configuration for the next test
+$node->append_conf(
+ 'postgresql.conf', qq{
+ssl_sni = on
+ssl_cert_file = ''
+});
+$node->reload;
+$node->wait_for_log(qr/reloading configuration files/);

Isn't an offset missing from here?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexandre Felipe 2026-09-23 08:25:52 Re: SLOPE - Planner optimizations on monotonic expressions.
Previous Message Yuhang Qiu 2026-09-23 07:58:25 Re: [PATCH] Use bounded GIN pending-list cleanup in parallel autovacuum