| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Yilin Zhang <jiezhilove(at)126(dot)com> |
| Subject: | pg_stat_database.checksum_failures misses single-page failures in backups |
| Date: | 2026-08-17 13:11:17 |
| Message-ID: | CAN4CZFN+Bi6XmaH8zOdMWjoycYFx9nKtOr+dzQf0o-UQ+Rdqmw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!
This issue was reported by Yilin Zhang in another backup related thread[1]
When basebackup finds exactly one corrupted page in a file, the backup
fails as expected with a per-page warning and then an error. However,
it doesn't update the statistics, because that update is currently
inside the per-file summary for 2 or more checksum failures.
This issue seems to exists since the introduction of the feature (6b9e875f728).
The attached patch moves the statistics report into its own block.
[1] : https://www.postgresql.org/message-id/34b127c.6e5d.1a00f5540f9.Coremail.jiezhilove%40126.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Report-single-page-checksum-failures-in-pg_stat_data.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-08-17 13:15:43 | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Previous Message | Amit Langote | 2026-08-17 13:07:13 | Re: Re-read conindid under the referenced table's lock in the RI fast path |