Re: [PATCH] Add pg_get_event_trigger_ddl() function

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add pg_get_event_trigger_ddl() function
Date: 2026-07-17 21:26:10
Message-ID: CAN4CZFMw4DUWYLKKxt_dYh02D1tYk8_efnmkikJsvyyM4Y8knQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello!

Should the function preserve the disabled state of an event trigger?

CREATE FUNCTION noop_evt() RETURNS event_trigger LANGUAGE plpgsql AS $$
BEGIN
END;
$$;
CREATE EVENT TRIGGER my_evt ON ddl_command_start EXECUTE FUNCTION noop_evt();
ALTER EVENT TRIGGER my_evt DISABLE;
SELECT pg_get_event_trigger_ddl('my_evt', false);

also REPLICA:

ALTER EVENT TRIGGER my_evt ENABLE REPLICA;
SELECT pg_get_event_trigger_ddl('my_evt', false);

and OWNER:

CREATE ROLE evt_owner_role SUPERUSER;
ALTER EVENT TRIGGER my_evt OWNER TO evt_owner_role;
SELECT pg_get_event_trigger_ddl('my_evt');

+ appendStringInfoString(&filters, ", ");
+
+ appendStringInfo(&filters, "'%s'", str);

Shouldn't this use quote_literal_cstr?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-07-17 21:59:10 Re: Fix GROUP BY ALL handling of ORDER BY operator semantics
Previous Message Andres Freund 2026-07-17 21:18:18 Re: Why clearing the VM doesn't require registering vm buffer in wal record