| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Yilin Zhang <jiezhilove(at)126(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Date: | 2026-08-17 12:52:18 |
| Message-ID: | CAN4CZFMq5x+kJBYvT5ezz4MLXTQg=wEGtu2JtPOpc3ui_7s9fQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> The failure is triggered at the end of perform_base_backup() when total_checksum_failures equals 1,
> via ereport(ERROR, errcode(XX001)).
> However, pg_stat_database.checksum_failures is not updated at all.
This seems like a separate issue existing for much longer, I'll submit
a separate patch about it.
> Judging by the current test cases,,
> pg_stat_database.checksum_failures appears to offer no detection capability beyond what ok($backup->finish) already provides.
I improved the tests a bit, while also adding the 32m shared buffers
change to 010. I kept this as a separate commit for easier review.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0003-Test-improvements-based-on-review-comments.patch | application/octet-stream | 6.0 KB |
| v5-0001-basebackup-do-not-verify-checksums-on-pages-from-.patch | application/octet-stream | 29.0 KB |
| v5-0002-Review-hackery.patch | application/octet-stream | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-08-17 12:54:08 | Re: basebackup: do not verify checksums on pages written before enabling checksums |
| Previous Message | Tomas Vondra | 2026-08-17 12:36:14 | Re: [PATCH] Add RetrieveInstrumentation hook for CustomScan providers |