Re: tablecmds: reject CLUSTER ON for partitioned tables earlier

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date: 2026-01-27 08:55:23
Message-ID: CAN4CZFMjyPYqNY6qD4ArRZKUyC4oEPAfu-OesfChGMwMq1CG_w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I added two new test cases in 0002 that trigger the check.

I also tested these scenarios previously. It's good that they are part
of the test suite, but they don't hit that error path. Verified with
this:

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 379f4d4ebaf..50f80724cb3 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -17857,9 +17857,7 @@ ATExecDropInherit(Relation rel, RangeVar
*parent, LOCKMODE lockmode)
Relation parent_rel;

if (rel->rd_rel->relispartition)
- ereport(ERROR,
- (errcode(ERRCODE_WRONG_OBJECT_TYPE),
- errmsg("cannot change inheritance of a partition")));
+ Assert(0);

/*
* AccessShareLock on the parent is probably enough, seeing that DROP

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2026-01-27 09:35:36 Re: Time to add FIDO2 support?
Previous Message Corey Huinker 2026-01-27 08:48:02 Re: Extended Statistics set/restore/clear functions.