| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Emptying oauth_validator_libraries doesn't stop OAuth logins |
| Date: | 2026-11-04 09:09:19 |
| Message-ID: | CAN4CZFMTasSzM_udbhm+UYrcYWxp4MuAzv2uNxme-sb+mvhBKQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
COMMERROR is a cosmetic change (during auth we send error or greater
to the client, not log), and the rest of the OAuth code uses ERROR,
which then gets promoted to FATAL.
The main question is how much information we should include in the
error message to the user, from that perspective Shihao's more generic
message might be better.
v3 is v1 + the COMMERROR and the error message change.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-oauth-Recheck-oauth_validator_libraries-during-au.patch | application/octet-stream | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2026-11-04 09:09:42 | Re: Fix ReadStream handling when heap rescan strategy changes |
| Previous Message | Peter Eisentraut | 2026-11-04 09:08:29 | Re: Add compiler option -fstrict-flex-arrays=1 |