| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: autovacuum: automatically propagate updated parameters |
| Date: | 2026-09-25 07:45:17 |
| Message-ID: | CAN4CZFMRsr_ncTii9JdNBAZnWcemmukrhe6maiBXt+oyjB1mrQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 24 Sep 2026, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> So if we want to
> use the condition variable, it seems better to me to have a dedicated
> wait function in vacuumparallel.c that waits until all indexes are
> completed, and then call WaitForParallelWorkersToFinish().
That'll bring back the more complicated approach of v2, and also make
this part of the code more complex.
While I didn't do proper measurements, my logic against it was similar
to what Manu already posted, that it seems harmless here and it is
significantly simpler than adding a cv.
Also, I think both issues could be solved in a more proper way with
more refactoring, but that seems excessive for 19. (And in that case,
going with a simple solution for 19 also seems like a good answer to
me)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-09-25 08:41:08 | Re: autovacuum: automatically propagate updated parameters |
| Previous Message | Tom Lane | 2026-09-25 05:05:54 | Re: BUG #19699: LIKE with a trailing escape fails to raise SQLSTATE 22025 for empty input |