Re: MERGE/SPLIT PARTITIONS issues/questions

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, jian he <jian(dot)universality(at)gmail(dot)com>
Subject: Re: MERGE/SPLIT PARTITIONS issues/questions
Date: 2026-08-12 20:38:04
Message-ID: CAN4CZFMNhEF85h7h1su30h9E4cExGKpSSViZ2EqggNqAX+Xtng@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hello

v3 looks good to me, I only have two nitpick comments:

1. MergePartitionsMoveRows now has a stale comment ("We also verify
check constraints againsy these rows")

2. I am unsure of the usefulness of some of the error hints, for example:
+ errhint("Set the replica identity of the new partition
explicitly after the operation."));

The hint is true, the user has to set up replica identity after the
merge if he needs it, but the operation can't be executed as-is, so
the user first have to solve the current situation. I also don't have
a better idea how to explain this without an overly long error hint,
so maybe it's good as is.

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Melanie Plageman 2026-08-12 20:48:36 Re: MERGE/SPLIT PARTITIONS issues/questions
Previous Message Zsolt Parragi 2026-08-12 19:53:17 Re: COPY TO regression with psql -c

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2026-08-12 20:48:36 Re: MERGE/SPLIT PARTITIONS issues/questions
Previous Message Nathan Bossart 2026-08-12 20:19:27 Re: Limit GRAPH_TABLE path combinations to prevent memory exhaustion