| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: datachecksums: handle invalid and dropped databases during enable |
| Date: | 2026-07-30 22:02:31 |
| Message-ID: | CAN4CZFM6kZf7+m06NwK8y+GE4qs4z0VZRTw9Wfzy+cYEHzWu+g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Apologies if this is expected behaviour, and I missed on some thread
> mentioning it.
It was somewhat intentional, but I agree that it is inconsistent and
maybe we should improve it.
The original code wanted to skip invalid databases, but also failed
because it tried connecting to them before this check. I fixed the
connection failure, but I also added a startup check about having no
invalid databases, because completing checksum enablement while there
are invalid databases didn't seem entirely safe. This seemed like a
good compromise because I wanted to avoid surprise process stops, but
since a failing drop database happening during the processing is
unlikely, handling this properly shouldn't be a real problem.
We could improve this either by adding your patch, or by removing
ErrorOnInvalidDatabases, but adding this patch seems to be safer to
me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shaun Thomas | 2026-07-30 22:02:45 | Re: Return pg_control from pg_backup_stop(). |
| Previous Message | Masahiko Sawada | 2026-07-30 21:48:39 | Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation |