| From: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)toroid(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-02-11 08:43:36 |
| Message-ID: | CAN1g5_FeDmiA9D8wdG2W6Lkq5CpubxOAqTmd2et9hsinTJtsMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for the feedback, I have incorporated the suggestions
and updated a new patch. PFA v2 patch.
> I think similar to bbstreamer_lz4_compressor_content() in
> bbstreamer_lz4_decompressor_content() we can change len to avail_in.
In bbstreamer_lz4_decompressor_content(), we are modifying avail_in
based on the number of bytes decompressed in each iteration. I think
we cannot replace it with "len" here.
Jeevan, Your v12 patch does not apply on HEAD, it requires a
rebase. I have applied it on commit 400fc6b6487ddf16aa82c9d76e5cfbe64d94f660
to validate my v2 patch.
Thanks,
Dipesh
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-support-client-side-compression-and-decompression-us.patch | text/x-patch | 22.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2022-02-11 08:48:43 | Re: Race condition in TransactionIdIsInProgress |
| Previous Message | tanghy.fnst@fujitsu.com | 2022-02-11 06:30:45 | RE: [BUG]Update Toast data failure in logical replication |