Re: Track skipped tables during autovacuum and autoanalyze

From: Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>
To: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Cc: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Date: 2026-09-18 14:52:54
Message-ID: CAN12+YLZZVc=UMi0-gDNx=0UJ2PUdhzuRiXijPZuHaQ3S4raug@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> One minor comment is:
>
> toast_vacuum_params.options |= VACOPT_PROCESS_MAIN;
> + toast_vacuum_params.options &= ~VACOPT_ANALYZE;
> toast_vacuum_params.toast_parent = relid;
>
> I wonder if this change is still necessary now that the filtering for TOAST
> tables has been added to pgstat_report_skipped_vacuum_analyze().
>
> If we keep this change, should we also add a comment explaining
> why it is needed?

Right. I removed it.

--
Sami

Attachment Content-Type Size
v17-0001-Track-skipped-vacuum-and-analyze-activity-per-re.patch application/octet-stream 45.9 KB
v17-0002-Add-injection-point-test-for-vacuum-skip_locked-.patch application/octet-stream 7.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Geier 2026-09-18 15:06:27 Re: Reducing relcache memory usage 2: shrink sizeof(RelationData)
Previous Message Tristan Partin 2026-09-18 14:52:42 Re: Add ASCII fast path to Unicode normalization functions