| From: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers |
| Date: | 2026-09-28 21:33:58 |
| Message-ID: | CAN12+YKo428-SWRW9KiWy866jcJRPPcph+Ue6pZAvQM1VaV5jw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Bharath,
Thanks for the feedback!
> 1/ At the end of parallel_vacuum_main(), do we need to gate the
> reporting of any remaining delay time on the accumulated delay time
> variable rather than on the GUC?
track_cost_delay_timing gates delay timing reporting elsewhere, so we should not
deviate from that. If the GUC is off by then, we should not accumulate
any timing
anyhow, even if parallel_vacuum_worker_delay_ns > 0
> 2/ Turning it on in the TAP test is probably not that costly on any of
> the CI or BF animals, since our tests don't vacuum anything large, so
> it shouldn't matter.
Right. I did not think it should matter.
--
Sami Imseih
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-09-28 21:48:27 | Re: Parallel vacuum: I/O timings in the log leave out the parallel workers |
| Previous Message | Matheus Alcantara | 2026-09-28 21:06:59 | Re: [PATCH v1] Fix for Bug#19724 - ALTER TYPE ... ALTER ATTRIBUTE triggers internal error for base type of domain with check |