Re: [PATCH] pgstat: Add helper to drop entries from a stats kind's hash

From: Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pgstat: Add helper to drop entries from a stats kind's hash
Date: 2026-11-04 17:57:19
Message-ID: CAN12+YKgvPH8m2YkyEjrc1K=o1CjdivFv_EFY5QWkFNLzFW2bQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Thanks for the update!
>
> v5 LGTM.
> Just one nit: I wonder if test_custom_stats_var_match_entry() and
> test_custom_stats_var_match_kind() could get more descriptive comments above
> their definitions.
>

I added some more explanation in v6-

--
Sami

Attachment Content-Type Size
v6-0001-pgstat-Add-kind-filter-to-pgstat_drop_matching_en.patch application/octet-stream 9.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-11-04 17:59:55 Re: Preferred way to submit a very large batch of bugs?
Previous Message Sami Imseih 2026-11-04 17:55:32 Re: [PATCH] pgstat: Add helper to drop entries from a stats kind's hash