Re: Reject WAIT FOR earlier in transaction-snapshot mode

From: Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>
To: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reject WAIT FOR earlier in transaction-snapshot mode
Date: 2026-09-11 15:58:39
Message-ID: CAN12+YKU=7_qeOV1Sa53Ux6XC9Vp-oLRJrfeV=ie=oM3-8SzKA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> 1) Could we use 0/0 instead of $lsn3 for these rejection tests? Since
> $lsn3 is deliberately unreachable, the first test can hang if the
> isolation check is missing.

I think I will keep this as-is. If the isolation-level rejection is
missing, the test is broken.

> 2) Also, the isolation-error pattern matches the old DETAIL, so
> matching the ERROR: prefix would verify that it is now the primary
> error.

v4 tightens the new recovery tests so the REPEATABLE READ cases match
the primary ERROR line, rather than the old DETAIL text. I also cleaned
up one test description.

> The cursor case better additionally check that the misleading
> isolation-level detail is absent.

I don't think we need that. The cursor case only needs to verify the
new primary error.

--
Sami Imseih
Amazon Web Services (AWS)

Attachment Content-Type Size
v4-0001-Fix-WAIT-FOR-rejection-errors.patch application/octet-stream 5.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Marcos Pegoraro 2026-09-11 16:03:27 Re: Support for 8-byte TOAST values, round two
Previous Message Tom Lane 2026-09-11 15:58:31 Re: pg_get_*_ddl() needs a redesign