| From: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: REPACK (CONCURRENTLY) loses missing values of columns added without a rewrite |
| Date: | 2026-09-24 14:43:14 |
| Message-ID: | CAN12+YKDTdP=_UxH9OVTyRZocyjDrz2YTcxD6kjt-10A7Xk6tQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks!
> I wonder why in your fix we keep a pointer to the whole relation instead
> of just to its tupledesc. What about the attached v4?
It was expedient. The tupledesc is all we need, so v4 is better. This LGTM.
> I ran your test with only CreateTupleDescCopy() to see how would your new
> test would fail (because such a descriptor wouldn't have the missing
> attrs), but it failed differently, because attnotnull is not set.
> Anyway, this was just a perhaps pointless experiment.
Thanks for checking. Right, CreateTupleDescCopy() would just reintroduce
the problem we're fixing.
v5 attached fixes indentation.
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Fix-REPACK-CONCURRENTLY-for-columns-added-without.patch | application/octet-stream | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2026-09-24 14:45:54 | Re: RI fastpath misses checking EXECUTE on functions |
| Previous Message | Nathan Bossart | 2026-09-24 14:33:13 | Re: Logical Implication |