Re: Add REPACK progress phases for logical decoding setup

> I've reviewed the patch and it mostly looks good to me. I have one
> minor comment:
>
> /* Find our decoding starting point. */
> + set_repack_worker_setup_phase(shared,
> + PROGRESS_REPACK_PHASE_INIT_LOGICAL_DECODING);
> DecodingContextFindStartpoint(ctx);
>
> While it's true that DecodingContextFindStartpoint() is the call that
> can take a long time in this phase, I'd recommend setting the
> INIT_LOGICAL_DECODING phase just before calling
> CreateInitDecodingContext(). Otherwise, if CreateInitDecodingContext()
> takes time for some reason, it would be reported as "enabling logical
> decoding", which the documentation describes as having nothing to do
> when effective_wal_level is already logical.

Makes sense. Done in v5

--
Sami Imseih
Amazon Web Services (AWS)