| From: | Ryan Lambert <ryan(at)rustprooflabs(dot)com> |
|---|---|
| To: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Mark Dilger <hornschnorter(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: FETCH FIRST clause PERCENT option |
| Date: | 2019-09-26 21:13:42 |
| Message-ID: | CAN-V+g_cG4_R9q25nccNoMrtwA7DsCuHh-G5_ygaj8PBFTWUDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 19, 2019 at 6:52 AM Surafel Temesgen <surafel3000(at)gmail(dot)com>
wrote:
> Hi Tom,
> In the attached patch i include the comments given
>
> regards
> Surafel
>
Patch v9 applies and passes make installcheck-world.
> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Date: 2019-09-05 22:26:29
> * I didn't really study the changes in nodeLimit.c, but doing
> "tuplestore_rescan" in ExecReScanLimit is surely just wrong. You
> probably want to delete and recreate the tuplestore, instead, since
> whatever data you already collected is of no further use. Maybe, in
> the case where no rescan of the child node is needed, you could re-use
> the data already collected; but that would require a bunch of additional
> logic. I'm inclined to think that v1 of the patch shouldn't concern
> itself with that sort of optimization.
I don't think this was addressed.
Ryan Lambert
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-26 21:13:49 | Re: range_agg |
| Previous Message | Alvaro Herrera | 2019-09-26 21:06:06 | Re: pgbench - allow to create partitioned tables |