| From: | Ryan Lambert <ryan(at)rustprooflabs(dot)com> |
|---|---|
| To: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Rémi Lapeyre <remi(dot)lapeyre(at)lenstra(dot)fr>, Eli Marmor <eli(at)netmask(dot)it>, David Steele <david(at)pgmasters(dot)net>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, gkokolatos(at)protonmail(dot)com |
| Subject: | Re: WIP: System Versioned Temporal Table |
| Date: | 2020-12-18 19:28:40 |
| Message-ID: | CAN-V+g_ZpK7cbx7szKV8Ma6sNNGy4d34sGh5FMy14h68F8gjBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 19, 2020 at 11:04 AM Surafel Temesgen <surafel3000(at)gmail(dot)com>
wrote:
>
> Attached is a rebased one.
> regards
> Surafel
>
Thank you for your work on this! The v7 patch fails on the current master
branch. Error from make:
gram.y:16695:1: error: static declaration of ‘makeAndExpr’ follows
non-static declaration
makeAndExpr(Node *lexpr, Node *rexpr, int location)
^~~~~~~~~~~
In file included from gram.y:58:0:
../../../src/include/nodes/makefuncs.h:108:14: note: previous declaration
of ‘makeAndExpr’ was here
extern Node *makeAndExpr(Node *lexpr, Node *rexpr, int location);
^~~~~~~~~~~
gram.y:16695:1: warning: ‘makeAndExpr’ defined but not used
[-Wunused-function]
makeAndExpr(Node *lexpr, Node *rexpr, int location)
^~~~~~~~~~~
The docs have two instances of "EndtTime" that should be "EndTime".
Ryan Lambert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2020-12-18 19:59:25 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | Pavel Borisov | 2020-12-18 18:54:54 | Re: [PATCH] Automatic HASH and LIST partition creation |