Re: Wired if-statement in gen_partprune_steps_internal

From: Ryan Lambert <ryan(at)rustprooflabs(dot)com>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wired if-statement in gen_partprune_steps_internal
Date: 2021-03-22 17:24:03
Message-ID: CAN-V+g9j75upDQHxDKfLZP8FVSjdCKfLkESZyotJx5t_738VNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Should the status of this patch be updated to ready for comitter to get in
line for Pg 14 deadline?

*Ryan Lambert*

On Sun, Mar 7, 2021 at 11:38 PM Amit Langote <amitlangote09(at)gmail(dot)com>
wrote:

> On Fri, Mar 5, 2021 at 7:50 AM Ryan Lambert <ryan(at)rustprooflabs(dot)com>
> wrote:
> > On Wed, Mar 3, 2021 at 11:03 PM Amit Langote <amitlangote09(at)gmail(dot)com>
> wrote:
> >>
> >> Sorry, this seems to have totally slipped my mind.
> >>
> >> Attached is the patch I had promised.
> >>
> >> Also, I have updated the title of the CF entry to "Some cosmetic
> >> improvements of partition pruning code", which I think is more
> >> appropriate.
> >
> > Thank you. The updated patch passes installcheck-world. I ran a
> handful of test queries with a small number of partitions and observed the
> same plans before and after the patch. I cannot speak to the quality of the
> code, though am happy to test any additional use cases that should be
> verified.
>
> Thanks Ryan.
>
> There's no need to test it extensively, because no functionality is
> changed with this patch.
>
> --
> Amit Langote
> EDB: http://www.enterprisedb.com
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-03-22 17:38:36 Re: [HACKERS] Custom compression methods
Previous Message Magnus Hagander 2021-03-22 17:22:52 Re: Proposal: Save user's original authenticated identity for logging