Re: Proposal for Signal Detection Refactoring

From: Chris Travers <chris(dot)travers(at)adjust(dot)com>
To: 9erthalion6(at)gmail(dot)com
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal for Signal Detection Refactoring
Date: 2018-12-03 05:56:59
Message-ID: CAN-RpxCKVvoH51BXwDWqOy64ynf9CDqEfv+Q7Au1jQCHse9Dyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 29, 2018 at 8:46 PM Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:

> > On Wed, Oct 10, 2018 at 7:10 PM Chris Travers <chris(dot)travers(at)adjust(dot)com>
> wrote:
> >
> >> More generally, I'd like this material to be code comments. It's the
> >> kind of stuff that gets outdated before long if it's kept separate.
> >
> > The problem is that code comments are not going to be good places to
> document "how do I check for pending actions?" That could be moved to the
> main SGML I guess.....
>
> I aggree with Peter here, for me it also feels more natural to have this
> information as code commentaries - at least if I would search for it that
> would
> be my first thought. As for "how do I..." part, I think there are alreasy
> similar commentaries in the code, which makes sense - this kind of
> questions
> usually appear when you're reading/writing some code.
>
> It doesn't look like there is much left to do in this discussion, but for
> now
> I'll move it to the next CF.
>

Ok will move this into code comments if there are no objections.

--
Best Regards,
Chris Travers
Head of Database

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com
Saarbrücker Straße 37a, 10405 Berlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2018-12-03 06:06:05 Re: [WIP] CREATE SUBSCRIPTION with FOR TABLES clause (table filter)
Previous Message John Naylor 2018-12-03 05:45:01 Re: WIP: Avoid creation of the free space map for small tables