Re: PATCH: psql tab completion for SELECT

From: Edmund Horner <ejrh00(at)gmail(dot)com>
To: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: psql tab completion for SELECT
Date: 2018-01-26 00:20:07
Message-ID: CAMyN-kCk9h1epCRN+GQ-RQs7rgGnD0MTbzRp+FeNAaqc=AoLNg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23 January 2018 at 21:47, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> wrote:
> Don't forget to include the list :-)
> I'm quoting the entirety of the message---which I would normally trim---for
> the archives.

Thanks for spotting that. Sorry list!

> If this were my patch, I'd have one query for 8.0, and then queries for all
> currently supported versions if needed. If 9.2 only gets 8.0-level
> features, that's fine by me. That limits us to a maximum of six queries.
> Just because we keep support for dead versions doesn't mean we have to
> retroactively develop for them. Au contraire.
>> I'll make another patch version, with these few differences.

I managed to do testing against servers on all the versions >= 8.0 and
I discovered that prior to version 8.1 they don't support ALL/ANY on
oidvectors; so I added another query form.

But I don't like having so many different queries, so I am in favour
of trimming it down. Can I leave that up to the committer to remove
some cases or do we need another patch?

> Great!

Here's another.

Attachment Content-Type Size
psql-select-tab-completion-v3.patch application/octet-stream 5.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-01-26 00:23:12 Re: ALTER TABLE ADD COLUMN fast default
Previous Message Tsunakawa, Takayuki 2018-01-26 00:08:17 RE: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory