| From: | Edmund Horner <ejrh00(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PATCH: psql tab completion for SELECT |
| Date: | 2018-03-06 07:31:31 |
| Message-ID: | CAMyN-kA4FNA=TOw7WBacoJGYh_u8traYXTOffR-WiCyV6YZKsw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I've reworked the SELECT completion patch to use the VersionedQuery
infrastructure.
I've also made it a schema query (for the functions), with an addon
for the attributes. This provides schema-aware completion.
Previously, addons to schema queries were appended verbatim; I've
changed this to use the same interpolation just as in the simple_query
case, so that the attributes can be filtered in the query. Otherwise,
relevant items can be omitted when they don't make it into the first
1000 rows in the query result, even when only a small number of items
are ultimately presented for completion.
Edmund
| Attachment | Content-Type | Size |
|---|---|---|
| psql-select-tab-completion-v5.patch | application/octet-stream | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2018-03-06 07:44:51 | Re: public schema default ACL |
| Previous Message | David Rowley | 2018-03-06 07:21:24 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |