| From: | Edmund Horner <ejrh00(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, kuntalghosh(dot)2007(at)gmail(dot)com |
| Subject: | Re: Fix for pg_stat_activity putting client hostaddr into appname field |
| Date: | 2018-04-05 22:46:27 |
| Message-ID: | CAMyN-kA3Oq6W-pY2Qc3njxKZLJNskp7goD6VRY2rFcO5LhFV7Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29 March 2018 at 20:46, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Mar 27, 2018 at 03:47:07PM +1300, Edmund Horner wrote:
>> But the stats array includes auxiliary processes, which means it has
>> NumBackendStatSlots items. The pointers for the aux process strings
>> are out of range. In the case of my query, the pointers for
>> st_appname in the aux processes happen to point into the
>> BackendClientHostnameBuffer segment.
>>
>> This patch uses NumBackendStatSlots for the sizes of those segments,
>> rather than MaxBackends.
>
> I am adding in CC Robert and Kuntal who worked on that (issue added as
> well to the older bug section in v11 open item list).
Thanks for making a note of it, Michael. I guess it should be
considered for the next patch release of v10 too?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Claudio Freire | 2018-04-05 22:59:59 | Re: Vacuum: allow usage of more than 1GB of work mem |
| Previous Message | David Rowley | 2018-04-05 22:37:30 | Re: Removing useless DISTINCT clauses |