| From: | Curt Tilmes <curt(at)tilmes(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Find additional connection service files in pg_service.conf.d directory |
| Date: | 2018-03-01 18:04:35 |
| Message-ID: | CAMv20O_4s3vzPRFHxiTtoTR_tBE8=bdwUWkwXmvDe5CHdXveCw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 1, 2018 at 11:36 AM, Curt Tilmes <curt(at)tilmes(dot)org> wrote:
> Do you have any specific suggestions? Would it help if I separated
> the new code into its own subroutine?
I broke the new directory search out into its own subroutine, so even
less impact on existing code.
>> In my experience with such .conf.d directories it's very useful to
>> filter names not matching a common pattern. Otherwise you end up with
>> editor tempfiles and such being used, which gets confusing.
>
> Suggestions? I'll make it skip over files prefixed with '.'.
> Anything else you suggest?
New patch skips over '.' dotfiles.
Curt
| Attachment | Content-Type | Size |
|---|---|---|
| pg_service.conf.d.patch.v2 | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-01 18:06:22 | Re: pgbench - add \if support |
| Previous Message | Andres Freund | 2018-03-01 18:04:06 | Re: [PoC PATCH] Parallel dump to /dev/null |