Re: [PATCH] Find additional connection service files in pg_service.conf.d directory

From: Curt Tilmes <curt(at)tilmes(dot)org>
To: "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Find additional connection service files in pg_service.conf.d directory
Date: 2018-03-05 13:16:07
Message-ID: CAMv20O9XHvSJO_ed84QfM6D4j5j4H0VMbw=ZB9_XuT33gYfsDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 5, 2018 at 7:45 AM, Andreas 'ads' Scherbaum
<adsmail(at)wars-nicht(dot)de> wrote:
> On Thu, Mar 1, 2018 at 7:40 PM, Curt Tilmes <curt(at)tilmes(dot)org> wrote:
>> On Thu, Mar 1, 2018 at 1:13 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Looked over this patch and found that you limit the directory entries to
> files only.
> Would it make sense to allow links as well? That would allow other
> programs/distributions to place a link in the config directory and point to
> a service file in their own directory.

I call stat(2), which from my understanding for a link will follow the
link and return
the information from the file linked to, not the link itself (which
lstat(2) would do).

I tried it out and it seems to work fine for links.

Curt

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-03-05 13:52:10 Re: Incorrect use of "an" and "a" in code comments and docs
Previous Message Pavel Stehule 2018-03-05 13:03:37 Re: Transform for pl/perl