Re: Transform for pl/perl

Hi

I am looking on this patch. I found few issues:

1. compile warning

I../../src/include -D_GNU_SOURCE -I/usr/include/libxml2
-I/usr/lib64/perl5/CORE -c -o jsonb_plperl.o jsonb_plperl.c
jsonb_plperl.c: In function ‘SV_FromJsonbValue’:
jsonb_plperl.c:69:9: warning: ‘result’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
return result;
^~~~~~
jsonb_plperl.c: In function ‘SV_FromJsonb’:
jsonb_plperl.c:142:9: warning: ‘result’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
return result;
^~~~~~

2. bad comment

/*
* SV_ToJsonbValue
*
* Transform Jsonb into SV --- propably reverse direction
*/

/*
* HV_ToJsonbValue
*
* Transform Jsonb into SV
*/

/*
* plperl_to_jsonb(SV *in)
*
* Transform Jsonb into SV
*/

3. Do we need two identical tests fro PLPerl and PLPerlu? Why?

Regards

Pavel