| From: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
|---|---|
| To: | Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [Patch]Add tab completion for DELETE ... USING |
| Date: | 2026-02-16 10:44:29 |
| Message-ID: | CAMtXxw96Q-K9Ltwk7uXcfspQJt2Rb+5-R-gDcjEWLHujoBtU3Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
Thank you for the updated patch.
On Mon, Feb 16, 2026 at 10:06 AM Tatsuya Kawata
<kawatatatsuya0913(at)gmail(dot)com> wrote:
>
> Hi Kirill-san,
>
> Thank you for your review and for updating the CF entry status!
>
I have gone through the discussions and found this as a relevant
patch. I manually tested the patch for Table completion, Keyword
completion after table, Alias case and Partial prefix completion and
the patch is working completely fine. And also make check passed
without regressions.
According to the patch, the implementation looks clean and consistent
with existing psql token-based completion patterns and LGTM.
Regards,
Soumya
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-02-16 10:49:09 | RE: Improve docs syntax checking and enable it in the meson build |
| Previous Message | lakshmi | 2026-02-16 10:44:16 | Re: Add a greedy join search algorithm to handle large join problems |