| From: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
|---|---|
| To: | Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: 001_password.pl fails with --without-readline |
| Date: | 2026-01-20 06:55:53 |
| Message-ID: | CAMtXxw-SdWZrzi=sHMOQA7guzs6=3Bx6ZLAchQKg04M0-GNBeQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
Thank you for confirming the full commit hash.
On Mon, Jan 19, 2026 at 3:16 PM Oleg Tselebrovskiy
<o(dot)tselebrovskiy(at)postgrespro(dot)ru> wrote:
>
> > Could you please share the full commit hash or branch that these
> > patches are based on? I will be happy to apply them again and re-run
> > the full test coverage once it is available.
>
> The full commit hash is 34740b90bc123d645a3a71231b765b778bdcf049,
> it’s the latest commit in repository on github, master branch, see [1]
>
> > I fetched all refs and tags locally and reset my tree to a clean
> > origin/master, but I am unable to locate commit 34740b9 in my
> > repository
>
> Maybe your origin is out-of-date or is just different?
> What does ‘git remote get-url origin’ say in your local repository?
My local workflow uses a fork repository for convenience, but the
origin is the official PostgreSQL repository. I reset my tree to
34740b90bc123d645a3a71231b765b778bdcf049 commit as per suggested and
have fetched all refs. But still I am unable to apply both v3 and v4
patches cleanly on that commit. Every time it fails with context
mismatches in BackgroundPsql.pm (around line 100), even on a clean
working tree.
error: patch failed: src/test/perl/PostgreSQL/Test/BackgroundPsql.pm:100
error: src/test/perl/PostgreSQL/Test/BackgroundPsql.pm: patch does not apply
error: patch failed: src/bin/psql/t/030_pager.pl:40
error: src/bin/psql/t/030_pager.pl: patch does not apply
Anyway I am trying it and will let you know the status once I complete
applying and testing the patches.
Regards,
Soumya
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-20 06:59:18 | Re: Fix comments for buf_id field of BufferDesc structure |
| Previous Message | shveta malik | 2026-01-20 06:51:03 | Re: pg_upgrade: optimize replication slot caught-up check |