| From: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
|---|---|
| To: | Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: 001_password.pl fails with --without-readline |
| Date: | 2026-01-19 09:34:47 |
| Message-ID: | CAMtXxw-HOci9H-=1HBYxk9RaJK-5jERcwrZBORr9aA3cx8USkA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
On Mon, Jan 19, 2026 at 2:15 PM Oleg Tselebrovskiy
<o(dot)tselebrovskiy(at)postgrespro(dot)ru> wrote:
>
> > I tried applying both the v3 and v4 patches on a clean branch tree
> > reset to the current origin/master, but neither of them applied
> > cleanly due to context mismatches in BackgroundPsql.pm and
> > 030_pager.pl. I think the patches need rebasing on the current master
> > before they can be tested further. I will be happy to re-test once
> > rebased patches are available.
>
> Just applied both v3 and v4 onto 34740b9 with no conflicts. I don’t
> see any commits that touch 030_pager.pl and BackgroundPsql.pm
> last few days, so maybe you still have your code changes from
> v1 or v2, or something from debugging v3 or v4? I see that you
> specified clean code tree, but for me both v3 and v4 applied with
> no trouble
>
Thank you for the guidance.
I fetched all refs and tags locally and reset my tree to a clean
origin/master, but I am unable to locate commit 34740b9 in my
repository, so I assume it may be a local or abbreviated hash. On a
fresh branch, both v3 and v4 patches failed to apply cleanly which
suggests a base mismatch rather than an issue with the patches
themselves.
Could you please share the full commit hash or branch that these
patches are based on? I will be happy to apply them again and re-run
the full test coverage once it is available.
Regards,
Soumya
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-01-19 09:38:17 | Re: Skipping schema changes in publication |
| Previous Message | lakshmi | 2026-01-19 09:25:43 | Re: parallel data loading for pgbench -i |