Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups
Date: 2016-12-29 09:28:22
Message-ID: CAMsr+YGh0dO2f3hLNXYoOq92uNPeCrrH8qC3a9S8L2UnS9RD8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29 December 2016 at 16:51, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 28 December 2016 at 22:16, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>
>> About the patch, it looks good to me for master with the minor exception
>> that:
>>> + appendStringInfo(buf, "pageno %d, xid %u",
>>> + trunc.pageno, trunc.oldestXid);
>>
>> This should probably say oldestXid instead of xid in the text description.
>
> Agreed.

Slightly amended attached.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Fix-a-minor-race-between-commit_ts-slru-truncation-a.patch text/x-patch 5.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-12-29 09:32:56 Re: proposal: session server side variables
Previous Message Magnus Hagander 2016-12-29 09:13:37 Re: Support for pg_receivexlog --format=plain|tar