Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups
Date: 2016-12-29 08:51:42
Message-ID: CAMsr+YFdMPWYy_yzLpSDn=pbJ=YoYH9hKX34Bqkjk_kVKA+d1A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 28 December 2016 at 22:16, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:

> About the patch, it looks good to me for master with the minor exception
> that:
>> + appendStringInfo(buf, "pageno %d, xid %u",
>> + trunc.pageno, trunc.oldestXid);
>
> This should probably say oldestXid instead of xid in the text description.

Agreed.

> About back-patching, I wonder if standby could be modified to move
> oldestXid based on pageno reverse calculation, but it's going to be
> slightly ugly.

Not worth it IMO.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2016-12-29 08:57:28 Re: proposal: session server side variables
Previous Message Pavel Stehule 2016-12-29 08:50:02 Re: proposal: session server side variables