Re: handling of heap rewrites in logical decoding

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: handling of heap rewrites in logical decoding
Date: 2018-03-21 15:38:03
Message-ID: CAMsr+YE6on=6MKyqxDdykM-XJsNtPjQKrn2Djt9Mt7amYjX4CQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21 March 2018 at 21:20, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 3/21/18 03:08, Craig Ringer wrote:
> > Why was relrewrite / Anum_pg_class_relrewrite inserted at position 28,
> > not appended to pg_class?
> >
> > I don't see how it'd cause any harm, I'm just curious about the
> rationale.
>
> Adding it at the end would not be appropriate, since those are
> variable-length fields. So I added it close to other fields of similar
> purpose.
>

Right, that makes sense. You're renumbering attnos anyway, so you might as
well put it somewhere logical.

>
>
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-21 15:51:14 Re: Hash join in SELECT target list expression keeps consuming memory
Previous Message Jeevan Chalke 2018-03-21 15:33:23 Re: [HACKERS] Partition-wise aggregation/grouping