From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: The pg_indent on on ftp is outdated |
Date: | 2017-12-29 01:18:00 |
Message-ID: | CAMsr+YHgo7WUwqjLZSeBosLw2at1LzMLyrGB5+VLG6kE2d7y6Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On 28 December 2017 at 23:59, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
>
> On Fri, Dec 22, 2017 at 1:33 AM, Craig Ringer <craig(at)2ndquadrant(dot)com>
> wrote:
>
>>
>>
>> On 21 Dec. 2017 22:42, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> > On Thu, Dec 21, 2017 at 12:42 PM, Craig Ringer <craig(at)2ndquadrant(dot)com>
>> > wrote:
>> >>> The pg_indent on www is outdated, and doesn't understand --version .
>> >>> https://www.postgresql.org/ftp/dev/
>>
>> > Is there a reason to keep it at all if its obsolete, or should we just
>> > delete it?
>>
>> The only reason I can think of why someone might still want that version
>> is if they're doing hacking on a pre-v10 branch and would like to indent
>> accordingly. If we have someplace for historical versions, I'd suggest
>> moving this tarball to there, and replacing it with a README that says
>> "go here for pre-v10 pgindent, or there for modern versions".
>>
>>
>> Add it as a branch in the git repo and backpatch the pgindent README?
>>
>> Hardly seems worth the hassle. It's not like back patches need tons of
>> worry about pgindent etc anyway.
>>
>
> That seems way overkill, yeah.
>
> We don't have a place for historic versions of this stuff. We have the
> archive directory but that's specifically a tarball of the last cvs stuff.
>
> I think a simple README is the way to go.
>
> I've cooked together something simple and pushed it. Please review and
> suggest changes.
>
>
Perfect. Thanks!
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2017-12-29 01:42:02 | Re: Contributing with code |
Previous Message | Thomas Munro | 2017-12-28 23:16:20 | Re: Condition variable live lock |
From | Date | Subject | |
---|---|---|---|
Next Message | Shubham Barai | 2018-01-02 15:31:08 | Re: [HACKERS] GSoC 2017: weekly progress reports (week 6) |
Previous Message | Magnus Hagander | 2017-12-28 15:59:00 | Re: The pg_indent on on ftp is outdated |