Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Álvaro Herrera <alvaro(dot)herrera(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches
Date: 2016-04-01 05:43:55
Message-ID: CAMsr+YHMamHM7MUZOPpJOa7e3Z+d8E+-W+xH984J3EfOrLfUQw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 1 April 2016 at 12:47, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:

> I'll prep a follow-up patch.
>
>
Done and attached.

Note that I can't use PG_GETARG_TRANSACTIONID directly since it's a macro
defined only in xid.c . It didn't seem worth extracting it and moving it to
postgres.h (where the other non-ADT-specific PG_GETARG_ macros are) or its
own new header just for this, so I've spelled it out each time.

I now remember that that's part of why I used bigint as an argument type.
The other part is that txid_current() returns bigint and there's no cast
from bigint to xid. So the tests would have to CREATE CAST or cast via
'text'. They now do the latter.

We should probably have a cast from bigint to/from xid, but the type is so
little-used that it's not much fuss.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Fix-test_slot_timelines-buildfarm-failure-on-32-bit-.patch text/x-patch 5.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2016-04-01 09:35:12 pgsql: Add Generic WAL interface
Previous Message Craig Ringer 2016-04-01 04:47:56 Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2016-04-01 05:50:10 EPQ recheck across HashJoin, what does it actuall check?
Previous Message Michael Paquier 2016-04-01 05:38:52 Re: [PATCH v10] GSSAPI encryption support