Re: Time to get rid of PQnoPasswordSupplied?

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Time to get rid of PQnoPasswordSupplied?
Date: 2015-06-23 08:57:06
Message-ID: CAMsr+YGLrDpTadh8d0YxV-VY0SwsurUbkKRexNfH6O8uO3jWeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22 June 2015 at 22:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> I do not follow Craig's argument that this is somehow connected to the
> wire protocol version.

Upon revisiting it, neither do I. You know when you read code and
think "what idiot wrote this" ... then "git blame" says it was you? I,
at least, know that feeling... and that's what reading that part of
that email was like.

Tom's right, of course. It's libpq-to-client. The string "fe_sendauth:
no password supplied" never goes over the wire; it's a response libpq
generates in response to an auth failure ErrorResponse message from
the server. It's only relevant for libpq-based clients.

Lets change it. PgAdmin-III will need a patch, but that's about the
only client I found that would care.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-06-23 09:05:43 Re: upper planner path-ification
Previous Message Kouhei Kaigai 2015-06-23 08:41:07 Re: upper planner path-ification