Re: PATCH: backtraces for error messages

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: backtraces for error messages
Date: 2018-06-21 04:35:10
Message-ID: CAMsr+YGFMVnFLRSf09GGgjUyxv3C0ytep9ftM8N2X1kLM-SkKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This is what the stacks look like btw

[2018-06-21 12:26:45.309 AWST] [7293] [] [] [:0] DEBUG: 00000:
find_in_dynamic_libpath: trying
"/home/craig/pg/10/lib/postgresql/pglogical.so"
[2018-06-21 12:26:45.309 AWST] [7293] [] [] [:0] LOCATION:
find_in_dynamic_libpath, dfmgr.c:639
[2018-06-21 12:26:45.309 AWST] [7293] [] [] [:0] STACK:
FRAME 0: find_in_dynamic_libpath +628
FRAME 1: expand_dynamic_library_name +205
FRAME 2: load_external_function +38
FRAME 3: LookupBackgroundWorkerFunction +197
FRAME 4: StartBackgroundWorker +549
FRAME 5: do_start_bgworker +466
FRAME 6: maybe_start_bgworkers +382
FRAME 7: reaper +895
FRAME 8: funlockfile +80
FRAME 9: __select +23
FRAME 10: ServerLoop +394
FRAME 11: PostmasterMain +4499

I wrote it because I got sick of Assert(false) debugging, and I was chasing
down some "ERROR: 08P01: insufficient data left in message" errors. Then I
got kind of caught up in it... you know how it is.

It also goes to show there are plenty of places you might want to get a
stack where you don't have an internal errcode or panic. I don't think that
idea will fly.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chen, Yan-Jack (NSB - CN/Hangzhou) 2018-06-21 05:11:02 "wal receiver" process hang in syslog() while exiting after receiving SIGTERM while the postgres has been promoted.
Previous Message Andres Freund 2018-06-21 03:43:11 Re: Speedup of relation deletes during recovery