[PATCH] Fix install-tests target for vpath builds

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH] Fix install-tests target for vpath builds
Date: 2020-04-23 04:55:19
Message-ID: CAMsr+YGCZkDzxRNacKWC9vzJfw54k0CxKxA-d9fEdiZvLQPjHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Patch 0001 fixes this issue with vpath postgres builds:

$ make -C src/test/regress install-tests
/usr/bin/install: cannot create regular file
'PGPREFIX/lib/postgresql/regress/PGPREFIX/src/test/regress/expected/errors.out':
No such file or directory
make: *** [GNUmakefile:90: install-tests] Error 1

(where PGPREFIX is your --prefix)

It also makes the install-tests target a toplevel target for convenience.

Three related bonus patches are attached in case anyone thinks they're a
good idea:

- 0002 changes the install location of src/test/regress's install-tests
output files (sql/, expected/ etc) to $(pkglibdir)/pgxs/src/test/regress so
that PGXS resolves it as $(top_srcdir)/src/test/regress, same as for
in-tree builds. Presently it installs in $(pkglibdir)/regress/ for some
reason. This patch applies on top of 0001. It will affect packagers.

- 0003 makes the toplevel install-tests target also install
src/test/isolation test resources and the test modules. This patch applies
on top of either 0001 or 0002, depending on whether you want to include
0002.

- 0004 makes the dummy 'check' target in pgxs.mk optional for extensions
that define the new PGXS variable NO_DUMMY_CHECK_TARGET . This lets
extensions that want to define a 'check' target do so without having make
complain at them about redefined targets. This patch is independent of the
others and can apply on master directly.

--
Craig Ringer http://www.2ndQuadrant.com/
2ndQuadrant - PostgreSQL Solutions for the Enterprise

Attachment Content-Type Size
0001-Fix-install-tests-target-for-vpath-builds.patch text/x-patch 1.9 KB
0003-Support-the-install-tests-target-for-the-rest-of-the.patch text/x-patch 9.3 KB
0004-Make-the-dummy-check-target-in-PGXS-makefiles-option.patch text/x-patch 1.6 KB
0002-Move-installed-pg_regress-test-sources-to-pkglibdir-.patch text/x-patch 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2020-04-23 04:57:55 Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Previous Message David Rowley 2020-04-23 04:36:48 Re: Parallel Append can break run-time partition pruning