Fix obsolete comment in GetSnapshotData

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix obsolete comment in GetSnapshotData
Date: 2017-03-29 04:00:38
Message-ID: CAMsr+YG0AzY1DZL5fw7Le_7y-kOYrxO_EVxvqmrCUHayo3YUqg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all

There's an outdated reference to GetOldestXmin(true, true) in
GetSnapshotData. It hasn't had that call signature for a long while
now. Update the comment to reflect the current signature.

diff --git a/src/backend/storage/ipc/procarray.c
b/src/backend/storage/ipc/procarray.c
index f32881b..4bf0243 100644
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -1556,7 +1556,8 @@ GetMaxSnapshotSubxidCount(void)
* older than this are known not running any more.
* RecentGlobalXmin: the global xmin (oldest TransactionXmin across all
* running transactions, except those running LAZY VACUUM). This is
- * the same computation done by GetOldestXmin(true, true).
+ * the same computation done by
+ * GetOldestXmin(NULL, PROCARRAY_FLAGS_DEFAULT|PROCARRAY_FLAGS_VACUUM)
* RecentGlobalDataXmin: the global xmin for non-catalog tables
* >= RecentGlobalXmin
*

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rafia Sabih 2017-03-29 04:02:43 Re: [COMMITTERS] pgsql: Improve access to parallel query from procedural languages.
Previous Message Kyotaro HORIGUCHI 2017-03-29 03:46:49 show "aggressive" or not in autovacuum logs